Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA - Removing k8s tests from vpa tests #2807

Merged

Conversation

krzysied
Copy link
Contributor

@krzysied krzysied commented Feb 7, 2020

Assuming that we want to run only vpa test maybe it is worth to not build and to not run k8s test.
Especially just only for skipping them :)

Most impartant chahes are in:

  • vertical-pod-autoscaler/e2e/v1/e2e_test.go
  • vertical-pod-autoscaler/e2e/v1beta2/e2e_test.go

Others are vendor update.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2020
@krzysied
Copy link
Contributor Author

krzysied commented Feb 7, 2020

/assign @bskiba

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 7, 2020
@bskiba
Copy link
Member

bskiba commented Feb 7, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit e7988a6 into kubernetes:master Feb 7, 2020
@krzysied krzysied deleted the vpa_remove_kubernetes_tests branch February 7, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants